Use slices and cmp packages instead of sort#4951
Merged
Conversation
Migrate all `sort.Slice`, `sort.SliceStable`, and `sort.Strings` calls to their standard library equivalents introduced in Go 1.21: `slices.SortFunc`, `slices.SortStableFunc`, and `slices.Sort`. Add `forbidigo` lint rules to prevent reintroduction. See https://go.dev/doc/go1.21#slices Co-authored-by: Isaac
renaudhartert-db
approved these changes
Apr 13, 2026
andrewnester
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate from the
sortpackage to theslicesandcmppackages across the codebase.The
slicespackage (stable since Go 1.21, extended in Go 1.23) provides type-safe, generic alternatives tosort. Go 1.23 addedslices.Sortedandslices.SortedFunc, making the full migration more compelling since thesortimport can often be dropped entirely.Key replacements:
sort.Strings→slices.Sortsort.Slice→slices.SortFuncsort.SliceStable→slices.SortStableFuncThe original prompt identified ~25
sort.Stringscall sites and ~3sort.SliceStablecall sites across ~46 files importingsort. This is a low-risk, mechanical migration.The
.golangci.yamlconfiguration is updated to flag any new usage of thesortpackage.Test plan
make test)make lint)This pull request was AI-assisted by Isaac.